Update Docker #1

New Issue

yc · 2023-10-25T09:22:23+02:00

yc commented

2023-10-25 09:22:23 +02:00

Update dockerfile and compose to build a minimal container with Swagger like in oc-discovery component.
The docker-compose.yml shall be used for the current project and a docker-compose-prereq.yml shall be used for running dependencies, both on the opencloud network.

Update dockerfile and compose to build a minimal container with Swagger like in oc-discovery component. The docker-compose.yml shall be used for the current project and a docker-compose-prereq.yml shall be used for running dependencies, both on the opencloud network.

yc added the

Kind/Feature

Priority/High

labels 2023-10-25 09:22:23 +02:00

pb was assigned by yc

2023-10-25 09:22:24 +02:00

root added this to the OpenCloud project 2023-10-25 21:17:02 +02:00

pb commented

2023-10-30 15:42:59 +01:00

Need to update the configuration process, currently doesn't support the way oc-discovery runs in docker :

Several variables are defined in the conf.app file
Causes the binary to crash

root@68ccd23e8112:/app# oc-catalog 
2023/10/30 14:41:48.425 [D]  init global config instance failed. If you do not use this, just ignore it.  open conf/app.conf: no such file or directory

=> implementing onion to handle environment variables

Need to update the configuration process, currently doesn't support the way oc-discovery runs in docker : - Several variables are defined in the conf.app file - Causes the binary to crash ``` root@68ccd23e8112:/app# oc-catalog 2023/10/30 14:41:48.425 [D] init global config instance failed. If you do not use this, just ignore it. open conf/app.conf: no such file or directory ``` => implementing onion to handle environment variables

pb commented

2023-10-31 10:37:36 +01:00

Changed the architecture of the conf, moved it from models/conf.go to conf/conf.go to avoid import cycle between the models and services packages. Now the package to import in conf, which is available to every other package without risking an import cycle.

pb commented

2023-10-31 14:55:56 +01:00

Identified some code that prevents the module to be compiled and then run outside of its directory.
It seems like the swagger is regenerated each time the server is launched. Actually there is a line in oc-catalog/routers/router.go that reads :

	//Force regenerate swagger before consuming the data
	 bee.GenerateDocs(".")

When running the binary in a scratch container or a folder different from the one where it was built, it generates a "parsing error".

I am still trying to understand why this part of the code was written and if we can get ride of it now that we generate the swagger in the Dockerfile with

RUN timeout 15 bee run -gendoc=true -downdoc=true -runmode=dev || :

Identified some code that prevents the module to be compiled and then run outside of its directory. It seems like the swagger is regenerated each time the server is launched. Actually there is a line in oc-catalog/routers/router.go that reads : ``` //Force regenerate swagger before consuming the data bee.GenerateDocs(".") ``` When running the binary in a scratch container or a folder different from the one where it was built, it generates a "parsing error". I am still trying to understand why this part of the code was written and if we can get ride of it now that we generate the swagger in the Dockerfile with ``` RUN timeout 15 bee run -gendoc=true -downdoc=true -runmode=dev || : ```

pb commented

2023-11-02 16:04:16 +01:00

Dockerfile has been reduced to a minimal size (30 Mb) by using a scratch image and generating the swagger during the build. Several modifications happened :

Added the configuration process with onion and json files
Modified the router initiation method : bee.GenerateDocs removed to prevent I/O errors in the container
Modified the services initiation : use of the conf file to retrieve mongo address
Modified the compose file :
- Mapped localhost 49618 to container 8080, so that we don't have to change the listening port inside the beego app
- Removed the build instruction that caused image to be rebuild when doing a compose up

Dockerfile has been reduced to a minimal size (30 Mb) by using a scratch image and generating the swagger during the build. Several modifications happened : - Added the configuration process with onion and json files - Modified the router initiation method : bee.GenerateDocs removed to prevent I/O errors in the container - Modified the services initiation : use of the conf file to retrieve mongo address - Modified the compose file : - Mapped localhost 49618 to container 8080, so that we don't have to change the listening port inside the beego app - Removed the build instruction that caused image to be rebuild when doing a compose up

Sign in to join this conversation.