Components are not linked anymore after adding settings #5

New Issue

pb · 2024-03-22T16:12:52+01:00

pb commented

2024-03-22 16:12:52 +01:00

When we edit the settings of a component, oc-catalog stop recognising it as part of a link/an arrow

Illustration :

First we connect a DC and a computing componant, there are no error logs

Then we edit the computing component to add a command and some args :

Once we validate we see the error appearing in the error log :

When we edit the settings of a component, oc-catalog stop recognising it as part of a link/an arrow **Illustration** : First we connect a DC and a computing componant, **there are no error logs** ![image](/attachments/61d99652-9a88-447c-b37c-2fa85f1248fd) Then we edit the computing component to add a command and some args : ![image](/attachments/dae1089a-1ca1-4129-b94d-388e3f7154ed) Once we validate we see the error appearing in the error log : ![image](/attachments/a3bfc5fd-d200-4316-9ded-9a670eed6b5c)

image.png

55 KiB

image.png

51 KiB

image.png

53 KiB

pb self-assigned this 2024-03-22 16:13:10 +01:00

pb commented

2024-03-22 19:43:50 +01:00

The MxGraphModel object sees the mxCell but can't read it properly. When testing we see that it give an ID that is parent's id + 1 and doesn't recognise the rID :

The MxGraphModel object sees the mxCell but can't read it properly. When testing we see that it give an ID that is parent's id + 1 and doesn't recognise the rID : ![image](/attachments/13a23af5-14bb-40b0-ad0e-e4b5340e981a)

image.png

93 KiB

pb commented

2024-03-28 15:22:40 +01:00

Refactored some code from models/workflow.go to extract a method that transform mxCell to componants : func (wf Workflow) mxCellToComponant(cell MxCell, ws Workspace) (resObj ResourceObject,err error, issues []error).
The returned object is updated to take the original ID from the object tag.

Now we have to create a method to add the user's input to the stored object

Refactored some code from `models/workflow.go` to extract a method that transform mxCell to componants : `func (wf Workflow) mxCellToComponant(cell MxCell, ws Workspace) (resObj ResourceObject,err error, issues []error)`. The returned object is updated to take the original ID from the object tag. Now we have to create a method to add the user's input to the stored object

pb commented

2024-03-29 17:03:32 +01:00

implemented user input processing into the specific object of the current workflow (with commit 10ec990a15adeecd9fe6d0230ebc3381b6845f87) but the bug has reappeared.
Starting to look into what throws these alerts

implemented user input processing into the specific object of the current workflow (with commit `10ec990a15adeecd9fe6d0230ebc3381b6845f87`) but the bug has reappeared. Starting to look into what throws these alerts

pb commented

2024-03-29 17:59:57 +01:00

implemented user input processing into the specific object of the current workflow (with commit 10ec990a15adeecd9fe6d0230ebc3381b6845f87) but the bug has reappeared.
Starting to look into what throws these alerts

Corrected in 95f0864bbb4d60925c76c193f1381b7edb4e0044, wrong logic in the previous code that removed a mxCell while it should not.

> implemented user input processing into the specific object of the current workflow (with commit `10ec990a15adeecd9fe6d0230ebc3381b6845f87`) but the bug has reappeared. > Starting to look into what throws these alerts Corrected in `95f0864bbb4d60925c76c193f1381b7edb4e0044`, wrong logic in the previous code that removed a mxCell while it should not.

pb added reference bugfix/settings_handling

2024-03-29 18:03:16 +01:00

pb added the

Kind/Bug

label 2024-03-29 18:03:31 +01:00

pb closed this issue

2024-03-29 18:03:45 +01:00

Sign in to join this conversation.