Components are not linked anymore after adding settings #5
Labels
No Label
Kind/Bug
Kind/Doc
Kind/Feature
Kind/Security
Kind/Testing
Priority/High
Priority/Low
Priority/Medium
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: core/deprecated-oc-catalog#5
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
When we edit the settings of a component, oc-catalog stop recognising it as part of a link/an arrow
Illustration :
First we connect a DC and a computing componant, there are no error logs
Then we edit the computing component to add a command and some args :
Once we validate we see the error appearing in the error log :
The MxGraphModel object sees the mxCell but can't read it properly. When testing we see that it give an ID that is parent's id + 1 and doesn't recognise the rID :
Refactored some code from
models/workflow.go
to extract a method that transform mxCell to componants :func (wf Workflow) mxCellToComponant(cell MxCell, ws Workspace) (resObj ResourceObject,err error, issues []error)
.The returned object is updated to take the original ID from the object tag.
Now we have to create a method to add the user's input to the stored object
implemented user input processing into the specific object of the current workflow (with commit
10ec990a15adeecd9fe6d0230ebc3381b6845f87
) but the bug has reappeared.Starting to look into what throws these alerts
Corrected in
95f0864bbb4d60925c76c193f1381b7edb4e0044
, wrong logic in the previous code that removed a mxCell while it should not.