From 80ef56bbc415d479623a2896f8b377c3b7e864fb Mon Sep 17 00:00:00 2001 From: admju Date: Wed, 11 Sep 2024 13:43:29 +0000 Subject: [PATCH] Gestion err download --- src/tool/kubectl_test.go | 13 ++++++++----- src/utils/download.go | 5 +++++ 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/src/tool/kubectl_test.go b/src/tool/kubectl_test.go index 05cd39f..b15b046 100644 --- a/src/tool/kubectl_test.go +++ b/src/tool/kubectl_test.go @@ -1,7 +1,6 @@ package tool import ( - "fmt" "path/filepath" "testing" @@ -55,14 +54,18 @@ EOF version, err1 := install.Version(dest) assert.Equal(t, "v1.30.3", version, "TestToolKubectl error") - - fmt.Println(" err1 ", err1) - + assert.Nilf(t, err1, "TestToolKubectl error") } func TestToolKubectlErr(t *testing.T) { + httpmock.Activate() + defer httpmock.DeactivateAndReset() + + httpmock.RegisterResponder("GET", "http://test/1.0", + httpmock.NewStringResponder(404, "")) + data := ToolData{Bin: TEST_DEST_DIR, Name: "test", Version: "1.0", @@ -75,5 +78,5 @@ func TestToolKubectlErr(t *testing.T) { err := install.Download() - assert.NotNilf(t, err, "error message %s", "Download") + assert.NotNilf(t, err, "error message %s", err) } diff --git a/src/utils/download.go b/src/utils/download.go index ef70df5..ec33676 100644 --- a/src/utils/download.go +++ b/src/utils/download.go @@ -1,6 +1,7 @@ package utils import ( + "fmt" "os" "io" "path" @@ -16,6 +17,10 @@ func DownloadFromUrl(dest string, url string, chmod os.FileMode) error { return err } defer resp.Body.Close() + if resp.StatusCode > 400 { + txt, _ := io.ReadAll(resp.Body) + return fmt.Errorf(string(txt)) + } out, err := os.Create(dest) defer out.Close()