Adjust + Test

models/bill/bill_mongo_accessor.go

@@ -1,63 +1,23 @@
 package bill
 
 import (
-	"cloud.o-forge.io/core/oc-lib/dbs"
 	"cloud.o-forge.io/core/oc-lib/logs"
 	"cloud.o-forge.io/core/oc-lib/models/utils"
 	"cloud.o-forge.io/core/oc-lib/tools"
 )
 
 type billMongoAccessor struct {
-	utils.AbstractAccessor // AbstractAccessor contains the basic fields of an accessor (model, caller)
+	utils.AbstractAccessor[*Bill] // AbstractAccessor contains the basic fields of an accessor (model, caller)
 }
 
 // New creates a new instance of the billMongoAccessor
 func NewAccessor(request *tools.APIRequest) *billMongoAccessor {
 	return &billMongoAccessor{
-		AbstractAccessor: utils.AbstractAccessor{
-			Logger:  logs.CreateLogger(tools.LIVE_DATACENTER.String()), // Create a logger with the data type
+		AbstractAccessor: utils.AbstractAccessor[*Bill]{
+			Logger:  logs.CreateLogger(tools.BILL.String()), // Create a logger with the data type
 			Request: request,
-			Type:    tools.LIVE_DATACENTER,
+			Type:    tools.BILL,
+			New:     func() *Bill { return &Bill{} },
 		},
 	}
 }
-
-/*
-* Nothing special here, just the basic CRUD operations
- */
-func (a *billMongoAccessor) DeleteOne(id string) (utils.DBObject, int, error) {
-	return utils.GenericDeleteOne(id, a)
-}
-
-func (a *billMongoAccessor) UpdateOne(set utils.DBObject, id string) (utils.DBObject, int, error) {
-	// should verify if a source is existing...
-	return utils.GenericUpdateOne(set, id, a, &Bill{})
-}
-
-func (a *billMongoAccessor) StoreOne(data utils.DBObject) (utils.DBObject, int, error) {
-	return utils.GenericStoreOne(data.(*Bill), a)
-}
-
-func (a *billMongoAccessor) CopyOne(data utils.DBObject) (utils.DBObject, int, error) {
-	return utils.GenericStoreOne(data.(*Bill), a)
-}
-
-func (a *billMongoAccessor) LoadOne(id string) (utils.DBObject, int, error) {
-	return utils.GenericLoadOne[*Bill](id, func(d utils.DBObject) (utils.DBObject, int, error) {
-		return d, 200, nil
-	}, a)
-}
-
-func (a *billMongoAccessor) LoadAll(isDraft bool) ([]utils.ShallowDBObject, int, error) {
-	return utils.GenericLoadAll[*Bill](a.getExec(), isDraft, a)
-}
-
-func (a *billMongoAccessor) Search(filters *dbs.Filters, search string, isDraft bool) ([]utils.ShallowDBObject, int, error) {
-	return utils.GenericSearch[*Bill](filters, search, (&Bill{}).GetObjectFilters(search), a.getExec(), isDraft, a)
-}
-
-func (a *billMongoAccessor) getExec() func(utils.DBObject) utils.ShallowDBObject {
-	return func(d utils.DBObject) utils.ShallowDBObject {
-		return d
-	}
-}

models/bill/tests/bill_test.go

@@ -0,0 +1,95 @@
+package bill_test
+
+import (
+	"testing"
+
+	"cloud.o-forge.io/core/oc-lib/models/bill"
+	"cloud.o-forge.io/core/oc-lib/models/common/enum"
+	"cloud.o-forge.io/core/oc-lib/models/order"
+	"cloud.o-forge.io/core/oc-lib/models/utils"
+	"cloud.o-forge.io/core/oc-lib/tools"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+// ---- Bill model ----
+
+func TestBill_StoreDraftDefault(t *testing.T) {
+	b := &bill.Bill{}
+	b.StoreDraftDefault()
+	assert.True(t, b.IsDraft)
+}
+
+func TestBill_CanDelete_Draft(t *testing.T) {
+	b := &bill.Bill{}
+	b.IsDraft = true
+	assert.True(t, b.CanDelete())
+}
+
+func TestBill_CanDelete_NonDraft(t *testing.T) {
+	b := &bill.Bill{}
+	b.IsDraft = false
+	assert.False(t, b.CanDelete())
+}
+
+func TestBill_CanUpdate_StatusChange_NonDraft(t *testing.T) {
+	b := &bill.Bill{Status: enum.PENDING}
+	b.IsDraft = false
+	set := &bill.Bill{Status: enum.PAID}
+	ok, returned := b.CanUpdate(set)
+	assert.True(t, ok)
+	assert.Equal(t, enum.PAID, returned.(*bill.Bill).Status)
+}
+
+func TestBill_CanUpdate_SameStatus_NonDraft(t *testing.T) {
+	b := &bill.Bill{Status: enum.PENDING}
+	b.IsDraft = false
+	set := &bill.Bill{Status: enum.PENDING}
+	ok, _ := b.CanUpdate(set)
+	assert.False(t, ok)
+}
+
+func TestBill_CanUpdate_Draft(t *testing.T) {
+	b := &bill.Bill{Status: enum.PENDING}
+	b.IsDraft = true
+	set := &bill.Bill{Status: enum.PAID}
+	ok, _ := b.CanUpdate(set)
+	assert.True(t, ok)
+}
+
+func TestBill_GetAccessor(t *testing.T) {
+	b := &bill.Bill{}
+	acc := b.GetAccessor(&tools.APIRequest{})
+	assert.NotNil(t, acc)
+}
+
+func TestBill_GetAccessor_NilRequest(t *testing.T) {
+	b := &bill.Bill{}
+	acc := b.GetAccessor(nil)
+	assert.NotNil(t, acc)
+}
+
+// ---- GenerateBill ----
+
+func TestGenerateBill_Basic(t *testing.T) {
+	o := &order.Order{
+		AbstractObject: utils.AbstractObject{UUID: "order-uuid-1"},
+	}
+	req := &tools.APIRequest{PeerID: "peer-abc"}
+	b, err := bill.GenerateBill(o, req)
+	require.NoError(t, err)
+	assert.NotNil(t, b)
+	assert.Equal(t, "order-uuid-1", b.OrderID)
+	assert.Equal(t, enum.PENDING, b.Status)
+	assert.False(t, b.IsDraft)
+	assert.Contains(t, b.Name, "peer-abc")
+}
+
+// ---- SumUpBill ----
+
+func TestBill_SumUpBill_NoSubOrders(t *testing.T) {
+	b := &bill.Bill{Total: 0}
+	result, err := b.SumUpBill(nil)
+	require.NoError(t, err)
+	assert.Equal(t, 0.0, result.Total)
+}